Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contact modal frontend test timeouts in CI #1826

Closed
richardebeling opened this issue Oct 19, 2022 · 1 comment
Closed

Contact modal frontend test timeouts in CI #1826

richardebeling opened this issue Oct 19, 2022 · 1 comment
Labels
[C] Tests and CI New or better testing and CI [P] Minor Minor priority

Comments

@richardebeling
Copy link
Member

The contact-modal-opens-with-allow-editors-to-edit test in evap/static/ts/tests/frontend/contributor-evaluation-edit.ts (from #1809) fails sometimes, e.g. here: https://github.com/e-valuation/EvaP/actions/runs/3280049485/jobs/5400375416#step:9:8.
The other contact modal test is probably also affected.

I don't know if its a test failure (because the test waits for something to happen on the page that will not happen) or simply a timeout because the CI VM is running slowly. We probably want to have tests where we can distinguish between the two.

In #1809, we added CSS to skip all animations at some point. Maybe we can replace the "wait for element to become visible" instructions in the test now. I think I haven't checked that after adding the CSS.

@richardebeling richardebeling added the [C] Tests and CI New or better testing and CI label Oct 19, 2022
@janno42 janno42 added the [P] Minor Minor priority label Oct 23, 2022
@richardebeling
Copy link
Member Author

Oh, I missed this issue when I created #1848. Well, now they are duplicates. Right now, I'm very close to just removing the test since it annoys more than it helps right now, so I'm closing this issue instead of the newer one.

@richardebeling richardebeling closed this as not planned Won't fix, can't repro, duplicate, stale Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] Tests and CI New or better testing and CI [P] Minor Minor priority
Development

No branches or pull requests

2 participants