New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine query params on jupyter server proxy #150

Open

randomir opened this issue Dec 23, 2022 · 0 comments

Labels

Member

randomir commented Dec 23, 2022

Query params of the base (external URL) and local URL are not merged, rather base query replaces the local one.

dwave-inspector/dwave/inspector/proxies.py

Lines 56 to 58 in 6c2b52a

 return update_url_from( 

 url, config.jupyter_server_proxy_external_url, 

 path=lambda local, ext: urljoin(ext.path, f"{local.path}/proxy/{local.port}/".lstrip('/')))

randomir mentioned this issue

Add support for jupyter-server-proxy #144

Closed

randomir added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment