Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Betterfox user.js repo for NixOS #43

Open
theRoboxx opened this issue Jan 1, 2024 · 3 comments
Open

Betterfox user.js repo for NixOS #43

theRoboxx opened this issue Jan 1, 2024 · 3 comments

Comments

@theRoboxx
Copy link

I would like to create a repo for the betterfox user.js.
It's a more casual collection than arkenfox's one and enhances the browser experience.

So, I forked this project and noticed that the syntax from the betterfox user.js is a bit different than the arkenfox user.js.
I'm not sure if that's the main problem but I don't know why the github action does create empty files. Maybe there is a typo in my config?

Any ideas on how to fix or debug this problem?
Thanks in advance 😃.

@dwarfmaster
Copy link
Owner

The script generating the nix files from the user.js depends on the comments to have the right shape, in order to group the options by section and to include their documentation. As such, it fails on betterfox's user.js because the file is structured differently. You would need to replace the parser by another one for it to work, so I'm not sure how much of what I've done can be reused.

@e-tho
Copy link

e-tho commented Feb 8, 2024

I created my own fork since there had been no activity on yours @theRoboxx.

I've made good progress so far, I've rewritten the Perl scripts in Python while adapting the regexes to Betterfox comment formats, the extraction part works properly.

I'm currently trying to adapt the Home Manager module with type.nix but I have no experience with Nix debugging.

The data structure seems to match the expected format, yet I'm still facing this type mismatch:

error: value is a string while a set was expected

@dwarfmaster,
I'd really appreciate it if you could take a look when you have some time.

@HeitorAugustoLN
Copy link

I've just finished working on the initial version of betterfox-nix. And it is working just fine. So maybe this issue can be closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants