-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consider making go-fuzz a proper module itself #332
Comments
I'd suggest also filing an issue upstream; 1.18 is probably mostly settled at this point, and if they don't know about an issue, it definitely won't get addressed. :) |
I think it might be golang/go#49598, but I need to confirm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
go-fuzz has reasonable support for targeting modules (#274), but is not itself a module.
Currently, the easiest way to build go-fuzz locally with a recent Go toolchain might be to clone go-fuzz to $GOPATH/src/github.com/dvyukov/go-fuzz and then disable modules via
GO111MODULE=off
env var. From the go-fuzz repo root, you can then dogo install ./go-fuzz ./go-fuzz-build
or similar to get go-fuzz and go-fuzz-build binaries that then can be used to fuzz a module-based target with module mode enabled viaGO111MODULE=on
. (That said, multiple ways to do this, so "easiest" might be in the eye of the beholder).Note this is mostly a concern if you want to hack on go-fuzz, and not as much of a concern if you are just using go-fuzz, because you can just install it without a local repo and without worrying about module mode, such as doing the following from anywhere (assuming a semi-recent Go version):
I have the start of converting go-fuzz to a module, but right now, there are some annoying glitches with the dev Go 1.18 and Go 1.17 not agreeing with what needs to be in go.sum, which can then cause failures based on which version of Go is in use. (Or at least I think that was a problem recently -- I haven't checked just now to see if it is still the case, including because I'm a few yaks deep and that is a yak I am saving for later).
So I think it could be mildly helpful to make go-fuzz a module itself, but if so, I would suggest letting Go 1.18 settle down a bit more first.
The text was updated successfully, but these errors were encountered: