Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bork-generated changelogs include last PR from previous release #332

Open
duckinator opened this issue Nov 8, 2023 · 1 comment
Open

Comments

@duckinator
Copy link
Owner

duckinator commented Nov 8, 2023

e.g., v7.0.1 includes the PR for merging v7.0.0:

image

but this is in spite of the fact that the PR is included in the info for v7.0.0:

image

v7.0.0 also included the PR for the v6.0.1 release.

The relevant code is probably bork.github_api.GithubApi._relevant_to_changelog().

@nbraud
Copy link
Collaborator

nbraud commented Aug 1, 2024

Yes, relevant_to_changelog relies on a (strict) comparison of merge time and release time, as reported by Github's API.

I think the ideal solution would be to use the actual git history (or some API which exposes info from it) as this would be a lot more robust, even in cases where multiple release branches exist etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants