Add logo support to QR API

[steven-tey]

I've started adding this via #1279 but am currently blocked by vercel/satori#592 (though I do think there should be a workaround)

If you can figure out the bug and get this working, you'd win 750 points since this is one of the long-standing bugs that we've been facing 😅

[linear]

ENG-593 Add logo support to QR API

[RajuGangitla]

/assign

[oss-gg]

Assigned to @RajuGangitla! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

[RajuGangitla]

@steven-tey can i get more details about this issue ?

[steven-tey]

@RajuGangitla feel free to piggyback off the PR that I started – we basically want to add the ability to pass a custom logo to our QR code API. Currently it doesn't work for some reason, as detailed in vercel/satori#592. Would love for you to figure it out!

[CntrlX]

can i work on it?

[unrenamed]

@steven-tey Have you considered converting the SVG to a PNG or JPG file before passing it to ImageResponse? I mean if SVG is not a strict requirement for the return type, then this may be a viable option.

[saiyalamarty]

Tried a workaround on mobile, and img tag with src seems to work instead of image and href. Away on vacation and laptop, so can't submit a PR. Someone else can verify and implement.

Link to playground.

[steven-tey]

@saiyalamarty that looks really promising – anyone want to take this one up? Feel free to copy the implementation in my PR #1279 but adjust it to use @saiyalamarty's suggestion to see if it works 👀

[steven-tey]

@RajuGangitla are you still working on this?

[DeepaPrasanna]

May I have a try if no one's working?

[RajuGangitla]

@steven-tey let me try the @saiyalamarty solution and if i am not able to solve this issue by today night
i will unassing myself

[RajuGangitla]

/assign

[oss-gg]

Assigned to @RajuGangitla! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

[BharathxD]

/assign 😬

[oss-gg]

This issue is already assigned to another person. Please find more issues here.

[RajuGangitla]

@BharathxD you can assign yourself now

[BharathxD]

/assign

[oss-gg]

Assigned to @BharathxD! Please open a draft PR linking this issue within 48h ⚠️ If we can't detect a PR from you linking this issue in 48h, you'll be unassigned automatically 🕹️ Excited to have you ship this 🚀

[steven-tey]

This has been fixed 🤯 kudos to @BharathxD for the PR and @saiyalamarty for the pro-tip 🙏