Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust::Vec doesn't satisfy std::ranges::contiguous_range #1392

Open
cdesouza-chromium opened this issue Nov 9, 2024 · 0 comments
Open

rust::Vec doesn't satisfy std::ranges::contiguous_range #1392

cdesouza-chromium opened this issue Nov 9, 2024 · 0 comments

Comments

@cdesouza-chromium
Copy link

We have had failures passing rust::Vec to span types like the one in Chromium, as it doesn't satisfy this requirement, even though it would be better if it did.
cdesouza-chromium added a commit to cdesouza-chromium/cxx that referenced this issue Nov 9, 2024
@cdesouza-chromium
Slice<T>::iterator to be contiguous and random_access
3f04db0 
`rust::Vec` fails `std::ranges::contiguous_range` checks as those have
to satisfy `random_access_range`, and `contiguous_iterator`. This has
caused mismatches with certain `span` types in other codebases.

This PR adds the necessary increment and concept category to
`Slice<T>::iterator`, to correct this issue.

Bug: dtolnay#1392
@cdesouza-chromium cdesouza-chromium mentioned this issue Nov 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cdesouza-chromium