Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible bug in step 1 #17

Open
bertaveira opened this issue Dec 6, 2022 · 1 comment
Open

Possible bug in step 1 #17

bertaveira opened this issue Dec 6, 2022 · 1 comment

Comments

@bertaveira
Copy link

I am not totally familiar with the algorithm so I might be missunderstanding but comparing with the paper and logically I see a potential issue.

In this line: https://github.com/danielTobon43/DBScan-PCL-Optimized/blob/master/dbscan/src/dbScan.cpp#L214

The pointQueue is cleared. But it is only cleared if it is bigger than a specified value. This seems weird. Should we clear every new iteration. This can result in an incomplete cluster being merged with another very far away. The centroid can be miles away from any of its points in this case. Seems weird but I might be wrong

@td43
Copy link
Collaborator

td43 commented Dec 7, 2022

Hi @bertaveira,

Hope you find well.

Well, as I mentioned in the README and just re-adapted the dbscan project from the dbscan-octrees repository, so I did not implement the logic in that module.

Regarding your question, I am really open to contributions and improvements, if you think there is a potential bug I encourage you to open a PR so we can compare the clustering process before - after the fixed bug and merge any patch if need it.

Take care!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants