Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Per Subdomain Secret #55

Open
sebthom opened this issue Aug 6, 2020 · 1 comment
Open

[Feature Request] Per Subdomain Secret #55

sebthom opened this issue Aug 6, 2020 · 1 comment

Comments

@sebthom
Copy link

sebthom commented Aug 6, 2020

Please add the ability to specify a dedicated secret for a given subdomain.

E.g. via environment variable

docker run -it -d \
    -p 8080:8080 \
    -p 53:53 \
    -p 53:53/udp \
    -e SHARED_SECRET=changeme \
    -e SECRET_mysubdomain1=changeme1 \
    -e SECRET_mysubdomain2=changeme2 \
    -e ZONE=example.org \
    -e RECORD_TTL=3600 \
    --name=dyndns \
    davd/docker-ddns:latest
@Golit
Copy link

Golit commented Aug 28, 2020

I created a pull request #59 where it is possible to use ddnskeys to have restricted access to a subdomain as defined in the zone file with update-policy. The shared secret will be still the same for all domains but further checking is done by the bind9 server with the ddnskey. Therefor you have to make sure that the default ist to not have access without a ddnykey.

This method may break compatibility with existing systems since it adds a variable to the request. For the future it may be a good idea to remove the current "shared secret check" and replace it with ddnskeys in a way to keep compatibility. By using ddnskeys we can archive ACL by delegating the task to the bind9 server itself.

But there is not much support for it right now and to get it to work requires some manual adjustments.

Golit added a commit to Golit/docker-ddns that referenced this issue Aug 31, 2020
The rest-api does not need to check the shared secret because bind itself
can check it. This change also allows to have different shared secrets for
different zones.

See dstapp#55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants