Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dataproducer): make access check optional in entity_label (#1382) #1383

Open
wants to merge 3 commits into
base: 8.x-4.x
Choose a base branch
from
Open

feat(dataproducer): make access check optional in entity_label (#1382) #1383

wants to merge 3 commits into from

Conversation

edurenye
Copy link

@edurenye edurenye commented Dec 1, 2023

Fixes #1382

@edurenye
Copy link
Author

edurenye commented Dec 1, 2023

I'll try to fix the tests

@edurenye
Copy link
Author

edurenye commented Dec 1, 2023

BTW this is related to https://www.drupal.org/sa-contrib-2023-050

@edurenye
Copy link
Author

edurenye commented Dec 4, 2023

The issue with the tests is actually a bug in DataProducerExecutionTrait and has an issue for it: #1233

DataProducerExecutionTrait does not care about the dafault value, so it needs to be specified.

I just made a workarround for the tests with a todo that marks that the 'access' default value can be removed after that issue is fixed.

@Kingdutch Kingdutch added the 4.x label Dec 27, 2023
klausi
klausi requested changes May 30, 2024
View reviewed changes
Copy link
Contributor

@klausi klausi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, i think this requires a bit of tweaking and a new test case where we demonstrate that access checking is ignored when this parameter is set to FALSE.

src/Plugin/GraphQL/DataProducer/Entity/EntityLabel.php Outdated Show resolved Hide resolved
src/Plugin/GraphQL/DataProducer/Entity/EntityLabel.php Outdated Show resolved Hide resolved
src/Plugin/GraphQL/DataProducer/Entity/EntityLabel.php Outdated Show resolved Hide resolved
tests/src/Kernel/DataProducer/EntityTest.php Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klausi klausi klausi requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
4.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make access check optional in the EntityLabel data producer
3 participants
@edurenye @klausi @Kingdutch