-
Notifications
You must be signed in to change notification settings - Fork 940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create releases for drupal-project #425
Comments
Not relying on dev dependencies is a good thing, and i thought about a tagging releases in the fast. But i had trouble finding the a proper version scheme, that fits. Packagist would show the version of the template not necessarily the version of Drupal core. This mighty be confusing for some users. |
Is it possible, to tag this repository (the composer-repo) with the drupal core version? I am building docker containers from your drupal-project (https://hub.docker.com/r/feikede/drupal8-docker/), thanks, but unfortunately it's not possible to have reliable release tags on the containers with a general 8.x-dev tag here (or I need to patch the deps in your composer.json). |
This would also be useful if you want to download an older version to test upgrading. |
Maybe something like
Although that would mean much more tagging. And probably fixating the Drupal version in the Then maybe
|
Or would fixating the Drupal version for every release be a desired thing?
|
On the other hand. Starting with just |
The requirements for versioning are:
Note that using Format candidates:
To me, the most unambiguous format is |
Yeah, I like |
@leymannx I suggest tagging as Alternatively, we can start from minor: |
Tagging is good, but the version number should be SemVer compliant. Otherwise it will not appear on Packagist and therefore cannot be used with ‘composer create-project’. |
@webflo – Ah I tried this https://jubianchi.github.io/semver-check/#/version/10.x-1.0.0 and it said "green" but I guess that's a false positive. @AlexSkrypnyk – I also prefer SemVer and if |
The other alternative is to follow Drupal core - option 4 from the list bove
|
What about some strange major version something like 1010 or 10010 (and 1008, 1009, 10011 etc.)? |
Some numeric pattern that reflects 10.x-10 how could that look like? |
Something that avoids the confusion that we follow core. |
https://github.com/webflo/drupal-project-test has tag "10.x-1.0.0" and it does not work on packagist https://packagist.org/packages/webflo/drupal-project-test |
Make this repo the dev repo and package it up or sync it to another repo when you do a release. |
This doesn't help with the version naming. |
The recommended template also has no releases, right? |
Linking SemVer definition https://semver.org/#backusnaur-form-grammar-for-valid-semver-versions Since Packagist is out of our control and it only allows SemVer, we can only solve this within SemVer format. They are saying that it is "strongly encouraged", but practically, based on the tests done above, it looks like they do not support anything more complex. Looking at what has been proposed in this thread, to me, We can add a line to |
I've created this question in Packagist repo (feel free to jump in there to explain things better) composer/packagist#1451 |
SemVer build metadata works on Packagist. https://packagist.org/packages/webflo/drupal-project-test#11+1.0.0 We could try use use [CORE-MAJOR]+[OUR-Version-Number]. |
@webflo This actually turns our version into build metadata, making it ignored when determining versions precedence. This may have other side effects that depend on a specific implementation of the spec by Packagist.org https://semver.org/#spec-item-10 |
I'd like to post the following instructions on the /download page on Drupal.org:
However, I'd prefer that it require a stable tag for drupal-project rather than asking users to rely on a dev dependency. It seems to be setting a bad example.
Would you be willing to begin cutting tags for drupal-project?
The text was updated successfully, but these errors were encountered: