fix(sheets-ui): ime input move cursor #4521
Open
+33
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View Deployment
|
Playwright test results
Details
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #4521 +/- ##
==========================================
- Coverage 32.68% 32.67% -0.01%
==========================================
Files 2597 2597
Lines 134555 134557 +2
Branches 29940 29942 +2
==========================================
- Hits 43975 43968 -7
- Misses 90580 90589 +9 ☔ View full report in Codecov by Sentry. |
wzhudev
approved these changes
Jan 20, 2025
| export const ShiftClearSelectionValueShortcutItem: IShortcutItem = { | ||
| id: ClearSelectionContentCommand.id, | ||
| // when focusing on any other input tag do not trigger this shortcut | ||
| preconditions: (contextService) => whenSheetEditorFocused(contextService), |
There was a problem hiding this comment.
Suggested change
| preconditions: (contextService) => whenSheetEditorFocused(contextService), | |
| preconditions: whenSheetEditorFocused, |
There is no need to wrap in another anonymous arrow function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close https://github.com/dream-num/univer-pro/issues/1400
close #4038
Pull Request Checklist