Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up controller by just throwing exceptions and rely on the exception filter. #6

Open
bobend opened this issue Oct 11, 2016 · 2 comments

Comments

@bobend
Copy link
Member

bobend commented Oct 11, 2016

eg. change

throw new HttpResponseException(Request.CreateErrorResponse(HttpStatusCode.BadRequest, "Machinename must be specified"));

to

throw new ArgumentNullException("Machinename must be specified",nameof(machineName));
@bobend
Copy link
Member Author

bobend commented Oct 11, 2016

This will also make the unittests more readable.

@mchadrdk
Copy link

Initial cleanup in 7304156

Changing the rest of the HttpResponseExceptions would take away the friendly error message from ModelState validation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants