Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose hunspell version with --version #229

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

drahnr
Copy link
Owner

@drahnr drahnr commented Nov 4, 2021

What does this PR accomplish?

  • 🦚 Feature

Currently it's not clear which hunspell version is used without additional user interaction.
The goal of this PR to close this gap and replace the manual actions with API in both hunspell and logic around it to obtain the hunspell version.

Ref #221

Changes proposed by this PR:

Introduce a ::version into the hunspell API re-exposing some C define / function. Also provide how the hunspell lib was linked (vendored, static, dynamic).

Notes to reviewer:

Most of the changes will be in drahnr/hunspell-rs or hunspell-sys, the PR merely exposes them via --version.

📜 Checklist

  • Works on the ./demo sub directory
  • Test coverage is excellent and passes
  • Documentation is thorough

@drahnr drahnr self-assigned this Nov 4, 2021
@drahnr drahnr added checker / hunspell hunspell checker related topics dependency An issue related to a dependency display 💻 Influencing how the output is rendered enhancement 🦚 New feature or request internal ⚙️ Internal issues or TODOs labels Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
checker / hunspell hunspell checker related topics dependency An issue related to a dependency display 💻 Influencing how the output is rendered enhancement 🦚 New feature or request internal ⚙️ Internal issues or TODOs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant