-
Notifications
You must be signed in to change notification settings - Fork 876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eval on a single shard does not log exec to journal #2519
Comments
adiholden
added
bug
Something isn't working
urgent
Important issue that needs to be fixed asap
MANAGED
labels
Feb 1, 2024
Will follow up with a separate quick PR, but generally #2376 will be a proper solution |
Okay, let's merge it before the remaining refactoring, it doesn't rely much on the parts left. I'll polish it and it's ready for review |
@romange PTAL at the PR if you want this issue closed 🙄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When running eval on a single shard we have an optimisation for a single hop
inside Service::EvalInternal if (CanRunSingleShardMulti(sid, *params, *tx)
When this optimisation is taking place we log to journal all the executed commands in the script with MULTI opcode but when finishing running the script we do not journal EXEC opcode.
This bug is causing replica to get stuck on execution and memory continues to grow untill oom occurs.
The text was updated successfully, but these errors were encountered: