Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eval on a single shard does not log exec to journal #2519

Closed
adiholden opened this issue Feb 1, 2024 · 4 comments · Fixed by #2531
Closed

Eval on a single shard does not log exec to journal #2519

adiholden opened this issue Feb 1, 2024 · 4 comments · Fixed by #2531
Assignees
Labels
bug Something isn't working MANAGED urgent Important issue that needs to be fixed asap

Comments

@adiholden
Copy link
Collaborator

When running eval on a single shard we have an optimisation for a single hop
inside Service::EvalInternal if (CanRunSingleShardMulti(sid, *params, *tx)
When this optimisation is taking place we log to journal all the executed commands in the script with MULTI opcode but when finishing running the script we do not journal EXEC opcode.
This bug is causing replica to get stuck on execution and memory continues to grow untill oom occurs.

@adiholden adiholden added bug Something isn't working urgent Important issue that needs to be fixed asap MANAGED labels Feb 1, 2024
@dranikpg
Copy link
Contributor

dranikpg commented Feb 1, 2024

Will follow up with a separate quick PR, but generally #2376 will be a proper solution

@romange
Copy link
Collaborator

romange commented Feb 1, 2024

@dranikpg how long do you think it will take to implement #2376? Maybe it's worth just wait for this PR to land?

@dranikpg
Copy link
Contributor

dranikpg commented Feb 1, 2024

Okay, let's merge it before the remaining refactoring, it doesn't rely much on the parts left. I'll polish it and it's ready for review

@dranikpg
Copy link
Contributor

dranikpg commented Feb 2, 2024

@romange PTAL at the PR if you want this issue closed 🙄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working MANAGED urgent Important issue that needs to be fixed asap
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants