Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Submit label depends on schema and unused key #1086

Open
waitingallday opened this issue Mar 21, 2024 · 0 comments
Open

Submit label depends on schema and unused key #1086

waitingallday opened this issue Mar 21, 2024 · 0 comments

Comments

@waitingallday
Copy link
Member

This is defaulting the analytics element_text to Submit which is probably right 99% of the time, but

  • FormKit schema doesn't use key
  • Doesn't check for components in the slot

ripple-framework/packages/ripple-ui-forms/src/components/RplForm/RplForm.vue

Line 84 in 2383bce

props.schema?.find((field) => field?.key === 'actions')?.label || 'Submit'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@waitingallday