Rename symbol failes to apply edits

[achobanov]

Type: Bug

Issue Description

Renaming a used class fails

Steps to Reproduce

Not sure, doesn't always fail

Expected Behavior

Should rename the class and it's usages

Actual Behavior

Doesn't rename at all, shows an error popup: "Failed to apply edits" or something similar

Logs

exthost.zip

Environment information

VSCode version: 1.93.1
C# Extension: 2.55.29
Using OmniSharp: false

Dotnet Information

.NET SDK: Version: 8.0.403 Commit: c64aa40a71 Workload version: 8.0.400-manifests.e0880c5d MSBuild version: 17.11.9+a69bbaaf5

Runtime Environment:
OS Name: Windows
OS Version: 10.0.19045
OS Platform: Windows
RID: win-x64
Base Path: C:\Program Files\dotnet\sdk\8.0.403\

.NET workloads installed:
Configured to use loose manifests when installing new manifests.
[android]
Installation Source: SDK 8.0.400, VS 17.11.35327.3
Manifest Version: 34.0.143/8.0.100
Manifest Path: C:\Program Files\dotnet\sdk-manifests\8.0.100\microsoft.net.sdk.android\34.0.143\WorkloadManifest.json
Install Type: FileBased

[aspire]
Installation Source: SDK 8.0.400, VS 17.11.35327.3
Manifest Version: 8.2.2/8.0.100
Manifest Path: C:\Program Files\dotnet\sdk-manifests\8.0.100\microsoft.net.sdk.aspire\8.2.2\WorkloadManifest.json
Install Type: FileBased

[ios]
Installation Source: SDK 8.0.400, VS 17.11.35327.3
Manifest Version: 18.0.8303/8.0.100
Manifest Path: C:\Program Files\dotnet\sdk-manifests\8.0.100\microsoft.net.sdk.ios\18.0.8303\WorkloadManifest.json
Install Type: FileBased

[maccatalyst]
Installation Source: SDK 8.0.400, VS 17.11.35327.3
Manifest Version: 18.0.8303/8.0.100
Manifest Path: C:\Program Files\dotnet\sdk-manifests\8.0.100\microsoft.net.sdk.maccatalyst\18.0.8303\WorkloadManifest.json
Install Type: FileBased

[maui-windows]
Installation Source: SDK 8.0.400, VS 17.11.35327.3
Manifest Version: 8.0.82/8.0.100
Manifest Path: C:\Program Files\dotnet\sdk-manifests\8.0.100\microsoft.net.sdk.maui\8.0.82\WorkloadManifest.json
Install Type: FileBased

Host:
Version: 8.0.10
Architecture: x64
Commit: 81cabf2857

.NET SDKs installed:
6.0.419 [C:\Program Files\dotnet\sdk]
7.0.410 [C:\Program Files\dotnet\sdk]
8.0.201 [C:\Program Files\dotnet\sdk]
8.0.302 [C:\Program Files\dotnet\sdk]
8.0.403 [C:\Program Files\dotnet\sdk]

.NET runtimes installed:
Microsoft.AspNetCore.App 3.1.32 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 6.0.27 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 7.0.20 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 8.0.2 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 8.0.6 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.AspNetCore.App 8.0.10 [C:\Program Files\dotnet\shared\Microsoft.AspNetCore.App]
Microsoft.NETCore.App 3.1.32 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 6.0.27 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 7.0.20 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 8.0.2 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 8.0.6 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.NETCore.App 8.0.10 [C:\Program Files\dotnet\shared\Microsoft.NETCore.App]
Microsoft.WindowsDesktop.App 3.1.32 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 6.0.27 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 7.0.20 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 8.0.2 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 8.0.6 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]
Microsoft.WindowsDesktop.App 8.0.10 [C:\Program Files\dotnet\shared\Microsoft.WindowsDesktop.App]

Other architectures found:
x86 [C:\Program Files (x86)\dotnet]
registered at [HKLM\SOFTWARE\dotnet\Setup\InstalledVersions\x86\InstallLocation]

Environment variables:
Not set

global.json file:
Not found

Learn more:
https://aka.ms/dotnet/info

Download .NET:
https://aka.ms/dotnet/download

Visual Studio Code Extensions

Extension	Author	Version	Folder Name
auto-close-tag	formulahendry	0.5.15	formulahendry.auto-close-tag-0.5.15
csdevkit	ms-dotnettools	1.13.9	ms-dotnettools.csdevkit-1.13.9-win32-x64
csharp	ms-dotnettools	2.55.29	ms-dotnettools.csharp-2.55.29-win32-x64
markdown-preview-github-styles	bierner	2.1.0	bierner.markdown-preview-github-styles-2.1.0
razor-switcher	LennartKleymann	1.0.0	lennartkleymann.razor-switcher-1.0.0
vscode-dotnet-runtime	ms-dotnettools	2.2.2	ms-dotnettools.vscode-dotnet-runtime-2.2.2
vscode-github-actions	github	0.27.0	github.vscode-github-actions-0.27.0
vscode-icons	vscode-icons-team	12.9.0	vscode-icons-team.vscode-icons-12.9.0
vscode-todo-highlight	wayou	1.0.5	wayou.vscode-todo-highlight-1.0.5
vscode-yaml	redhat	1.15.0	redhat.vscode-yaml-1.15.0
vscodeintellicode-csharp	ms-dotnettools	2.2.3	ms-dotnettools.vscodeintellicode-csharp-2.2.3-win32-x64

Extension version: 2.55.29
VS Code version: Cursor 0.42.5 (001668006cc714afd397f4ef0d52862f5a095530, 2024-11-14T00:33:36.512Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item	Value
CPUs	Intel(R) Core(TM) i5-8400 CPU @ 2.80GHz (6 x 2808)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: enabled_on direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_graphite: disabled_off video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled webnn: disabled_off
Load (avg)	undefined
Memory (System)	31.92GB (12.84GB free)
Process Argv
Screen Reader	no
VM	0%

[dibarbet]

A couple questions

1. Is the reference being renamed used cross language (e.g. in C# and in a Razor file)?
2. Can you confirm if the server sees the file in the correct project? I highly recommend pinning the active file context item in the language status bar:
   
3. Can you enable trace logging as described here - https://github.com/dotnet/vscode-csharp/blob/main/SUPPORT.md#collecting-general-logs to capture the trace logs when the rename fails?

[achobanov]

@dibarbet aren't trace logs available? I'm pretty sure I set em while reporting a previous issue. I'll set it up and post when I get an occurence.

I'm not entirely sure about the file I was renaming, it's likely to have been used in razor file. I'll look for that next time.

[dibarbet]

@achobanov the ones in the attached zip don't appear to be trace logs. Note - this latest release we did adjust the mechanism for configuring trace logs (see link above).

Once you've enabled trace logging, I'm most interested in the 'C#' output window logs and 'C# LSP Trace Logs' ones (though uploading the entire logs folder also works like you did before!)

[achobanov]

@dibarbet I'm reproducing this again: tried to rename class Participation

c#.txt

lsp.txt

[dibarbet]

Apologies for the delay here - thanks. It looks like the last rename in the logs contains a virtual Razor file which causes it to fail to apply.

"uri": "virtualcsharp-razor:///<truncated>ParticipationForm.razor__virtual.cs"

This is a known issue - renames fail to apply when the edits contain a Razor file as we are unable to map it.

[dibarbet]

@ryzngard would you mind transferring or closing as a duplicate if you have an umbrella issue tracking this?

[achobanov]

Please share the issue to track. I'd like to transition to VS Code as primary editor, but I need some of those features to work more reliably and would like to follow the progress.

Thanks