License scan is failing for wpf repo

[Winniexu01]

main build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2445462&view=logs&j=5df03f59-1349-559c-803f-5be5172cc74c&t=ce568090-a993-5067-a6ee-0405a2529741&l=26
release/9.0.1xx-preview4 build: https://dev.azure.com/dnceng/internal/_build/results?buildId=2445467&view=logs&j=5df03f59-1349-559c-803f-5be5172cc74c&t=ce568090-a993-5067-a6ee-0405a2529741

{
  "files": [
    {
      "path": "src/Microsoft.DotNet.Wpf/src/PresentationFramework/System/Windows/WindowBackdropType.cs",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Resources/Accent.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Resources/DefaultContextMenu.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Resources/DefaultFocusVisualStyle.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Resources/Fluent.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Resources/Fonts.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Resources/StaticColors.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Resources/Variables.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Resources/Theme/Dark.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Resources/Theme/HC1.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Resources/Theme/HC2.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Resources/Theme/HCBlack.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Resources/Theme/HCWhite.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Resources/Theme/Light.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/Button.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/Calendar.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/CheckBox.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/ComboBox.xaml",
      "detected_license_expression": "mit AND mpl-2.0"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/ContextMenu.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/DataGrid.xaml",
      "detected_license_expression": "mit AND (mpl-2.0 AND mit)"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/DatePicker.xaml",
      "detected_license_expression": "mit AND mpl-2.0"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/Expander.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/Frame.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/Label.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/ListBox.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/ListBoxItem.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/ListView.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/ListViewItem.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/Menu.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/MenuItem.xaml",
      "detected_license_expression": "mit AND mpl-2.0"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/Page.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/PasswordBox.xaml",
      "detected_license_expression": "mit AND mpl-2.0"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/ProgressBar.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/RadioButton.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/RichTextBox.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/ScrollBar.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/ScrollViewer.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/Separator.xaml",
      "detected_license_expression": "mit AND mpl-2.0"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/Slider.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/StatusBar.xaml",
      "detected_license_expression": "mit AND mpl-2.0"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/TabControl.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/TextBlock.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/TextBox.xaml",
      "detected_license_expression": "mit AND mpl-2.0"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/ToggleButton.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/ToolBar.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/ToolTip.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/TreeView.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/TreeViewItem.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    },
    {
      "path": "src/Microsoft.DotNet.Wpf/src/Themes/PresentationFramework.Fluent/Styles/Window.xaml",
      "detected_license_expression": "mit AND bsd-2-clause-views"
    }
  ]
}

More detail: scancode-results.json

[ellahathaway]

I think we can add bsd-2-clause-views to the list of allowed licenses. OSI says that it's a form of the bsd-simplified license, and we currently allow that. https://opensource.org/license/bsd-2-clause

[mthalman]

It is a false positive though. See my comment at dotnet/wpf#8870 (comment). Even though it's allowable, I would argue that we shouldn't include it when it's a false positive.

[omajid]

Shall I report the false positive to the scancode project?

[mthalman]

Shall I report the false positive to the scancode project?

Sounds good to me. Thanks!

[ellahathaway]

It is a false positive though. See my comment at dotnet/wpf#8870 (comment). Even though it's allowable, I would argue that we shouldn't include it when it's a false positive.

I see. I can add it to the exclusion list then? Or I can update the wpf baseline so we know when/if wpf resolves the issue of the differing licenses.

[mthalman]

It should be added as an exclusion with a comment saying it's a false positive.

[mthalman]

There's also this mpl-2.0 license showing up. I haven't investigated that.

[omajid]

I reported the two issues:

• bsd-2-clause-views: An MIT notice is identified as MIT AND BSD-2-Clause-Views aboutcode-org/scancode-toolkit#3767
• mpl-2.0: An MIT notice is identified as mit AND mpl-2.0 aboutcode-org/scancode-toolkit#3768