Signature help session is not triggered after typing comma in target-typed new expression inside return statement

[Peter-Juhasz]

Version Used: VS 17.13 P2.1

Steps to Reproduce:

20241218-1956-48.4765144.mp4

static A Do()
{
    return new("ASD"$$);
}

public record class A(string Id, int Count);

Expected Behavior:
Signature help session starts.

Actual Behavior:
Signature help session doesn't start.

[CyrusNajmabadi]

Debugged through. This is because the compiler is giving back an error type symbol when we ask what the type of this expression is (including the converted type of it).

While tehre's def a problem in that a specific constructor cannot be found. We should still be able to figure out the type here. Assigning to compiler to take a look (note: i think we've heard abotu this in teh past. not sure if there's a bug to dupe this against).

[CyrusNajmabadi]

Note: the compiler does return the right thing when tehre are no arguments (even though overload resolution fails tehre as well) . So it seems to be if there are args that do have errors that it then fails to figure out the type.

[davidwengier]

Ran in to this today, and also noticed completion doesn't offer parameter names making it very annoying to deal with constructors with lots of optional parameters. Probably the same root cause, but thought I'd comment because the experience is particularly painful in this scenario.