Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Opt into client side STJ serialization #73317

Open
dibarbet opened this issue May 2, 2024 · 2 comments · May be fixed by #72675
Open

Opt into client side STJ serialization #73317

dibarbet opened this issue May 2, 2024 · 2 comments · May be fixed by #72675
Assignees
@dibarbet
Labels
Area-IDE LSP issues related to the roslyn language server protocol implementation untriaged Issues and PRs which have not yet been triaged by a lead

Comments

@dibarbet
Copy link
Member

dibarbet commented May 2, 2024

We should tell the LSP client to use STJ for client side serialization. See #72675

This is currently blocked on Razor moving to APIs that do not depend on Newtonsoft.
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels May 2, 2024
@dibarbet dibarbet self-assigned this May 2, 2024
@dibarbet dibarbet added the LSP issues related to the roslyn language server protocol implementation label May 2, 2024
@dibarbet dibarbet linked a pull request May 2, 2024 that will close this issue
Draft
@CyrusNajmabadi
Copy link
Member

How much razor work is there? And are they signed up to do this soon?

@dibarbet
Copy link
Member Author

dibarbet commented May 3, 2024

Yes, everyone is moving over, @phil-allen-msft is p2 a good target for Razor?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dibarbet dibarbet

Labels
Area-IDE LSP issues related to the roslyn language server protocol implementation untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Opt into stj serialization on LSPclient dibarbet/roslyn
2 participants
@CyrusNajmabadi @dibarbet