Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set TrimMode with PublishAot #2676

Closed
breyed opened this issue Dec 13, 2024 · 0 comments · Fixed by #2687
Closed

Don't set TrimMode with PublishAot #2676

breyed opened this issue Dec 13, 2024 · 0 comments · Fixed by #2687
Assignees
@davidbritch
Labels
doc-enhancement Improve the current content [org] 📌 seQUESTered Identifies that an issue has been imported into Quest.

Comments

@breyed
Copy link
Contributor

breyed commented Dec 13, 2024 •
edited by sequestor bot
Loading

Trim a .NET MAUI app says to for trimming to set <TrimMode>full</TrimMode> (or partial). However, this isn't always correct. When using <PublishAot>true</PublishAot>, TrimMode should not be set.

/Users/runner/hostedtoolcache/dotnet/packs/Microsoft.iOS.Sdk.net9.0_18.1/18.1.9163/targets/Xamarin.Shared.Sdk.targets(538,3): warning : All assemblies must be processed by the linker when using NativeAOT. Please don't set neither the 'MtouchLink' nor the 'TrimMode' property, so that the build can default to linking all assemblies.

The guidance for trimming should cover the native AOT case.

Associated WorkItem - 356252
@dotnetrepoman dotnetrepoman bot added the ⌚ Not Triaged Not triaged label Dec 13, 2024
@davidbritch davidbritch self-assigned this Dec 17, 2024
@davidbritch davidbritch added doc-enhancement Improve the current content [org] 🗺️ reQUEST Triggers an issue to be imported into Quest. labels Dec 17, 2024
@dotnetrepoman dotnetrepoman bot removed the ⌚ Not Triaged Not triaged label Dec 17, 2024
@davidbritch davidbritch removed the Pri3 label Dec 17, 2024
@sequestor sequestor bot added 📌 seQUESTered Identifies that an issue has been imported into Quest. and removed 🗺️ reQUEST Triggers an issue to be imported into Quest. labels Dec 17, 2024
@dotnetrepoman dotnetrepoman bot added ⌚ Not Triaged Not triaged and removed ⌚ Not Triaged Not triaged labels Dec 17, 2024
@davidbritch davidbritch moved this from 🔖 Ready to 🏗 In progress in dotnet/docs-maui 2024 Sprints Dec 20, 2024
@davidbritch davidbritch mentioned this issue Dec 20, 2024
Merged
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in dotnet/docs-maui 2024 Sprints Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidbritch davidbritch

Labels
doc-enhancement Improve the current content [org] 📌 seQUESTered Identifies that an issue has been imported into Quest.
Projects
dotnet/docs-maui 2024 Sprints
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add note about nativeaot dotnet/docs-maui
2 participants
@breyed @davidbritch