-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trimming defaults don't use advised trimming behavior #2644
Comments
Hi @breyed The intent here is that users should either accept the trimming defaults or if they're going to change the defaults, do so across all build configurations. I appreciate that the language could use some clarification. |
@davidbritch What are the underlying technical reasons for the default of partial trimming for release but not debug on Android and Mac Catalyst? Intuitively, I would expect that if for example the user switched to full trimming, the same release/debug distinction would apply. I'm trying to understand why the guidance would be in the example to use full trimming in both release and debug. |
The guidance in the docs should be reconciled with guidance from @jonathanpeppers in dotnet/maui#26509 to not use " |
Generally, I don't think you should have to set This has some details about the current behavior, that we might improve in .NET 10: |
Trimming defaults vary by build configuration:
However, the trimming behavior advice says not to:
Either the behavior should be changed to match the advice or the advice should be updated to indicate when it is and is not recommended to condition
TrimMode
by configuration.Associated WorkItem - 350513
The text was updated successfully, but these errors were encountered: