Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpackaged app deployment #2607

Merged
merged 10 commits into from
Nov 7, 2024
Merged

Unpackaged app deployment #2607

merged 10 commits into from
Nov 7, 2024

Conversation

davidbritch
Copy link
Contributor

@davidbritch davidbritch commented Nov 7, 2024

@davidbritch davidbritch requested a review from BethMassi November 7, 2024 15:41
@davidbritch
Copy link
Contributor Author

@BethMassi Two questions:

  1. Is the ability to switch between packaged and unpackaged .NET 9 only, or also .NET 8? At the moment I limited that content in the doc to .NET 9.
  2. Maybe the new content should go at the top of the doc? I've tried it both ways around and I keep changing my mind on what works best. We can, if required, have different orderings in the .NET 8 and .NET 9 versions of the doc.

@BethMassi
Copy link
Contributor

Hi @davidbritch
The ability to switch in the VS IDE exists for .NET 8 and 9 projects (VS version 17.12). However, only .NET 9 projects default to Unpackaged. .NET 8 projects are unchanged (default to Packaged). I also think it's helpful to show the code changes that the IDE actually makes in the .csproj and launchSetting.json. If someone has defined multiple launch settings, then the IDE switch will not touch those entries.

@BethMassi
Copy link
Contributor

  1. Maybe the new content should go at the top of the doc? I've tried it both ways around and I keep changing my mind on what works best. We can, if required, have different orderings in the .NET 8 and .NET 9 versions of the doc.

I think it would be better in the .NET 9 version to jump right to the Windows debug target (since you get Unpackaged by default) and then show folks how they can switch to packaged if needed.

@davidbritch
Copy link
Contributor Author

@BethMassi Should be good now.

Copy link
Contributor

@BethMassi BethMassi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one suggestion.

docs/windows/includes/target-windows.md Show resolved Hide resolved
@davidbritch davidbritch merged commit 86fa5c5 into main Nov 7, 2024
4 checks passed
@davidbritch davidbritch deleted the dabritch-net9-unpackagedapps branch November 7, 2024 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.NET MAUI 9: Update doc to describe how .NET 9 uses unpackaged F5 to Windows
2 participants