Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarified differences between TargetNullValue and FallbackValue #2516

Merged
merged 9 commits into from
Oct 4, 2024
Merged

Clarified differences between TargetNullValue and FallbackValue #2516

merged 9 commits into from
Oct 4, 2024

Conversation

thimanshu1993
Copy link
Contributor

@thimanshu1993 thimanshu1993 commented Sep 24, 2024 •
edited by sequestor bot
Loading

Clarified differences between TargetNullValue and FallbackValue in data binding with examples.

Associated WorkItem - 320967

@thimanshu1993
Copy link
Contributor Author

@dotnet-policy-service agree

@thimanshu1993
Copy link
Contributor Author

Hi @davidbritch
It seems this PR get some issue related to guideline, however i pushed the latest changes now.
Kindly check once. Thanks in advance.

@thimanshu1993
Copy link
Contributor Author

Hi @davidbritch
Not sure but i feel now issue with Github guideline have been fixed in my latest commit and changes are good to be merged.
Kindly have a look.

@davidbritch
Copy link
Contributor

@thimanshu1993 Working my way through PRs now :)

@davidbritch davidbritch added the 🗺️ reQUEST Triggers an issue to be imported into Quest. label Oct 4, 2024
@davidbritch davidbritch self-requested a review October 4, 2024 13:55
@davidbritch davidbritch self-assigned this Oct 4, 2024
@sequestor sequestor bot added 📌 seQUESTered Identifies that an issue has been imported into Quest. and removed 🗺️ reQUEST Triggers an issue to be imported into Quest. labels Oct 4, 2024
@thimanshu1993
Copy link
Contributor Author

Thanks for the same @davidbritch because of you other contributors feels motivated to get things done.

davidbritch
davidbritch approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@davidbritch davidbritch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @thimanshu1993

@davidbritch davidbritch merged commit 8ad239b into dotnet:main Oct 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidbritch davidbritch davidbritch approved these changes

Assignees

@davidbritch davidbritch

Labels
📌 seQUESTered Identifies that an issue has been imported into Quest.
Projects
dotnet/docs-maui 2024 Sprints
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thimanshu1993 @davidbritch