New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a test to verify publish manifests #572

Open

DamianEdwards opened this issue Nov 14, 2024 · 0 comments

Labels

Member

DamianEdwards commented Nov 14, 2024 •

edited

Loading

From #570

Out of curiosity, if we wouldn't have ingested 9.0 GA yet (with the fixes), and we tried doing these changes, would a test(s) have failed as part of CI in this PR? If not, should it and should we add a test for it?

Not for this specific change, as it relates to publishing. We don't have any tests that verify the output of publish currently. The cheapest thing we could do is add tests to verify the manifests generated are what's expected. Of course any change that impacts the manifest would then require the "expected state" manifest to be updated. Logged #572 to track that idea.

DamianEdwards mentioned this issue

Remove workarounds in HealthChecksUI sample #570

Merged

DamianEdwards added the area-samples label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment