-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sample that send telemetry from the browser #409
Comments
I'm thinking we should just update the existing AspireWithJavaScript sample to do this. It has Angular, React, and Vue apps in it so seems like a good candidate to add this functionality. /Cc @IEvangelist |
Tried doing this, only to learn that it's not really well supported. I spoke with @vhvb1989 and @davidfowl on this, and here's the conclusion as to why we cannot do this with the
|
@IEvangelist everything you're referring to is regarding supporting this after publishing to ACA, correct? IIUC we could make the sample support it at dev time without much trouble but it wouldn't work after publishing, right? |
@DamianEdwards - Correct, I have it working locally for dev time support...that was still a bit of work though. So many different opinions about how each JS SPA framework handles building env vars. |
OK. I guess we just need to decide if we want to include it in the sample in that state then, perhaps with a note in the README. Given how many folks asked for the feature and the fact we made changes to unblock it, seems like it's worthwhile? |
Yeah, again I have this all working locally and correctly reporting browser telemetry for each SPA. I could add a note in the README.md to say something about the deployment not working. Perhaps, we should remove the Dockerfiles from the sample then too, as it's really confusing to include them since they will not work. |
Could we update the sample logic so that the client app gets the URL via a call to a backend API? |
See https://github.com/dotnet/aspire/tree/main/playground/BrowserTelemetry as an example of how to do this.
The text was updated successfully, but these errors were encountered: