Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview selection displays Height x Width instead of Width x Height #28517

Closed
jdcmsd opened this issue May 9, 2024 · 1 comment · Fixed by #28602
Closed

Preview selection displays Height x Width instead of Width x Height #28517

jdcmsd opened this issue May 9, 2024 · 1 comment · Fixed by #28602

Comments

@jdcmsd
Copy link
Contributor

jdcmsd commented May 9, 2024

Parent Issue

No response

Problem Statement

On the preview device list in the UVE Preview button, it displays the dimensions as {Height} x {Width} instead of {Width} x {Height}.

All links work correctly, all titles are correct; this is just a simple text issue with the dropdown.

Steps to Reproduce

  1. Open a page in the editor in QA Master
  2. Hit the Preview dropdown.
  3. See the following:

image

The device highlighted in that image illustrates it:

image

It displays properly in the editor; it's just HxW instead of WxH on the dropdown.

Acceptance Criteria

The dimensions should display as {Width}x{Height}.

dotCMS Version

dotcms-core 1.0.0-SNAPSHOT (May 09, 2024 1:25 PM), current on QA Master at the time of writing.

Proposed Objective

User Experience

Proposed Priority

Priority 4 - Trivial

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

@jdcmsd
Copy link
Contributor Author

jdcmsd commented May 9, 2024

#28520 should fix it! (Tested locally.)

image

image

@jdcmsd jdcmsd linked a pull request May 9, 2024 that will close this issue
@jdcmsd jdcmsd linked a pull request May 17, 2024 that will close this issue
github-merge-queue bot pushed a commit that referenced this issue May 21, 2024
Dimensions should display as `{Width} x {Height}` instead of `{Height} x
{Width}` in the dropdown; this just swaps them.

Solves #28517.

Redo of #28520, but this time I'm not
working off a fork, so that should simplify things!

Signed-off-by: Jamie Mauro <[email protected]>
spbolton pushed a commit that referenced this issue Jun 3, 2024
Dimensions should display as `{Width} x {Height}` instead of `{Height} x
{Width}` in the dropdown; this just swaps them.

Solves #28517.

Redo of #28520, but this time I'm not
working off a fork, so that should simplify things!

Signed-off-by: Jamie Mauro <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Internal QA
Development

Successfully merging a pull request may close this issue.

1 participant