CDROM_Interface pointer ownership issue #3620
Assignees
Labels
bug
Something isn't working
Comments
|
Working on a not-too-invasive solution of this. Basically, one owning store for all CDROM_Interface decedents. |
japsmits
changed the title
|
I'd suggest either adding some (temporary) log statements or setting a debugger breakpoint to confirm a double free happens in practice. Actual behavior can often be surprising. Either way, a cleanup of this would be welcome though. |
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Are you using the latest Dosbox-Staging Version?
Different version than latest?
Git
What Operating System are you using?
Windows 10
If Other OS, please describe
No response
Relevant hardware info
No response
Have you checked that no other similar issue already exists?
A clear and concise description of what the bug is.
The pointer created by new CDROM_Interface_Image gets stored in two places (CDROM_Interface_Image::images and CMmscdex::cdrom) and can get deleted in both places. This is undefined behaviour.
Steps to reproduce the behaviour.
Explain how to reproduce
Download URL of affected game or software
No response
Your configuration
No response
Provide a Log
No response
Code of Conduct & Contributing Guidelines
The text was updated successfully, but these errors were encountered: