Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cli_common: remove inner usages of get_asyncio_loop().run() #1032

Merged
merged 1 commit into from
May 26, 2024
Merged

cli_common: remove inner usages of get_asyncio_loop().run() #1032

merged 1 commit into from
May 26, 2024

Conversation

doronz88
Copy link
Owner

replace usages of get_asyncio_loop().run() with asyncio.run()

Close #1031

@doronz88
cli_common: remove inner usages of get_asyncio_loop().run()
e535513 
replace usages of `get_asyncio_loop().run()` with `asyncio.run()`

Close #1031
@doronz88 doronz88 mentioned this pull request May 26, 2024
Open
@doronz88 doronz88 merged commit 9f73ff2 into master May 26, 2024
17 checks passed
@doronz88 doronz88 deleted the bugfix/remove-get-asyncio-loop-usages branch May 26, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RuntimeError: Task RemoteServiceDiscoveryService.close() got Future attached to a different loop
1 participant
@doronz88