Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit filename #49

Open
MatheusRich opened this issue Aug 2, 2018 · 7 comments
Open

Edit filename #49

MatheusRich opened this issue Aug 2, 2018 · 7 comments
Labels

Comments

@MatheusRich
Copy link
Member

MatheusRich commented Aug 2, 2018

Editing the filename would be great! It can be either a button or a edit-in-place!

@MatheusRich MatheusRich added this to the 2.0 milestone Aug 2, 2018
@wilbertliu
Copy link
Contributor

Do you mean the ability to edit the last path of the URL @MatheusRich? 🤔
What if the new file name has already taken?
Have you already integrated a way to show an error to user?

@MatheusRich
Copy link
Member Author

MatheusRich commented Oct 9, 2018

@wilbertliu Actually this issue means editing the FILE name, not the route. Like this:

Let's suppose you have this file.
image

And you want to change the file name to the-coolest-file.png, resulting in something like this:
image

@vzqzac
Copy link
Contributor

vzqzac commented Oct 9, 2018

I've started some work on this to edit the uploaded file name! ActiveStorage is not helping though 😅 but I'm some of the way in

@wilbertliu
Copy link
Contributor

wilbertliu commented Oct 9, 2018 via email

@vzqzac
Copy link
Contributor

vzqzac commented Oct 9, 2018

What I thought (and started working on) is on having an Edit button (using font awesome icons), something like this:

image

And changing the file name to an input element once clicked using js and ajax to perform a patch request, I have slightly worked on this but if @wilbertliu wants to take it there's no problem, I didn't say before that I was taking it

@wilbertliu
Copy link
Contributor

The ball should be yours @MatheusRich 😀

@MatheusRich
Copy link
Member Author

It can be either a button or a edit-in-place (clicking twice on the filename). I'm open to the possibilities.

@vzqzac vzqzac mentioned this issue Oct 10, 2018
@MatheusRich MatheusRich modified the milestones: 2.0, 1.4 Dec 26, 2018
@MatheusRich MatheusRich removed this from the 1.4 milestone Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants