Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax Error with SOURCE_LOG_FILE in CHANGE REPLICATION SOURCE TO Command #8512

Open
TianyuZhang1214 opened this issue Oct 31, 2024 · 4 comments
Labels
customer issue enhancement New feature or request

Comments

@TianyuZhang1214
Copy link

Description:
A syntax error occurs when executing a replication query, specifically at position 141 near SOURCE_LOG_FILE. This error prevents the query from executing successfully, resulting in a warning log entry.

Error Details:

WARN[2796] error running query                           
connectTime="2024-10-31 13:54:16.815824 +0800 CST m=+7.077709710" 
connectionDb= connectionID=1 
error="syntax error at position 141 near 'SOURCE_LOG_FILE'" 
query="CHANGE REPLICATION SOURCE TO SOURCE_HOST='127.0.0.1', SOURCE_USER='root', SOURCE_PASSWORD='root', SOURCE_PORT=16345, SOURCE_LOG_FILE='binlog.000047', SOURCE_LOG_POS=157"

Steps to Reproduce:

  1. Execute the following replication command:
    CHANGE REPLICATION SOURCE TO 
    SOURCE_HOST='127.0.0.1', 
    SOURCE_USER='root', 
    SOURCE_PASSWORD='root', 
    SOURCE_PORT=16345, 
    SOURCE_LOG_FILE='binlog.000047', 
    SOURCE_LOG_POS=157;
  2. Observe the syntax error near SOURCE_LOG_FILE.

Expected Behavior:
The replication command should execute without any syntax errors, allowing replication to start as intended.

Actual Behavior:
The command fails with a syntax error, specifically indicating an issue near SOURCE_LOG_FILE.

Additional Context:
It appears that AWS RDS for MySQL and Azure Database for MySQL do not enable GTID by default, making support for SOURCE_LOG_FILE essential for proper replication setup.

@fulghum
Copy link
Contributor

fulghum commented Oct 31, 2024

Hi @TianyuZhang1214, thank you for opening such a well-written issue. You are correct that MySQL-to-Dolt replication currently only supports GTID positioning. GTID positioning is the more recent/modern positioning system for MySQL replication, and is generally preferred over log file positioning because it tends to be easier to configure and manage.

Adding support for log file based positioning would be possible of course. As a quick ballpark estimate... I'd guess it would probably take around three weeks to fully implement support for it. This is not work we currently have planned, but we're always happy to adapt our roadmap based on customer feedback.

That said, we do have customers using MySQL-to-Dolt replication successfully from cloud hosting providers like AWS and Azure. Have you already looking into enabling GTID support there? Here's some of AWS' documentation on enabling GTIDs with RDS MySQL deployments. Ultimately, I think GTID positioning is a more common and better supported option, and will also enable you to start replicating to Dolt much faster than us implementing log file positioning. If there are specific constraints that prevent you from using GTID positioning, I'd love to learn more. My current understanding is that GTID positioning is the recommended approach and should work in all cases where log file positioning works.

Let us know what you think!

@TianyuZhang1214
Copy link
Author

Thank you for your timely response! Here are our thoughts regarding GTID and Binlog file positioning:

Have you already looked into enabling GTID support there?

Yes, GTID can be manually enabled in the MySQL configurations on AWS and Azure, but it is disabled by default. Our goal is to support scenarios where users have not enabled GTID themselves.

We understand that GTID positioning is the recommended approach. Therefore, supporting Binlog file positioning is not an urgent requirement at this time. We can implement it once you provide support for it.

Thank you!

@fulghum fulghum added the enhancement New feature or request label Nov 1, 2024
@bpf120
Copy link

bpf120 commented Nov 4, 2024

@TianyuZhang1214 , we'd love to learn more about your Dolt use case. Feel free to email me or join our Discord if you want to share.

@TianyuZhang1214
Copy link
Author

@TianyuZhang1214 , we'd love to learn more about your Dolt use case. Feel free to email me or join our Discord if you want to share.

Absolutely! I’d be happy to share more about our project and our use of Dolt. We’re currently working on finalizing the documentation to make our project open-source. Once it’s ready, I’ll share all the details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
customer issue enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants