Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate DocumentManager::merge #2435

Open
malarzm opened this issue Apr 27, 2022 · 1 comment
Open

Deprecate DocumentManager::merge #2435

malarzm opened this issue Apr 27, 2022 · 1 comment
Labels

Comments

@malarzm
Copy link
Member

malarzm commented Apr 27, 2022

The merge method is removed from the ObjectManager interface in doctrine/persistence 3.0 and as such we are free to deprecate (and eventually remove) it as well. Throughout the years the merge operation was one of the most misused functionality across all Doctrine's data mappers. Having said that the merge functionality has its value when caching comes into play, especially since the ODM does not provide a second level cache (like ORM does). Removing merge without any replacement (as we plan) would effectively block users from upgrading to a next major version.

Given the circumstances we're not deprecating merge just yet, consider this issue as a friendly warning instead. If you use merging documents for performance reasons please do let us know! If no (valid TM) objections are raised and enough (TM) time passes we may proceed with deprecation process before the 3.0 release.

@malarzm malarzm added the Task label Apr 27, 2022
@malarzm malarzm added this to the 2.x milestone Apr 27, 2022
@malarzm malarzm modified the milestones: 2.x, 2.7.0 Dec 15, 2023
@malarzm
Copy link
Member Author

malarzm commented Dec 15, 2023

No concerns were raised for a year and a half, scheduling for 2.7.x

@alcaeus alcaeus removed this from the 2.7.0 milestone Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants