Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support --stop-timeout in create and run request #3168

Open
cweber-dbs opened this issue Aug 16, 2023 · 1 comment
Open

Support --stop-timeout in create and run request #3168

cweber-dbs opened this issue Aug 16, 2023 · 1 comment

Comments

@cweber-dbs
Copy link

cweber-dbs commented Aug 16, 2023

Issue #2449 was closed without merging the PR (#2909) . So this parameter is still missing.

Original issue:

API 1.25 added the --stop-timeout to the run command. It needs to be added to the docker API. https://docs.docker.com/engine/api/v1.25/#

Otherwise I received the following error:
TypeError: run() got an unexpected keyword argument 'stop_timeout'

@cweber-dbs cweber-dbs changed the title Support --stop-timeout in run request Support --stop-timeout in create and run request Aug 16, 2023
@cweber-dbs
Copy link
Author

There might be an other issue in the error handling in _create_container_args

    # All kwargs should have been consumed by this point, so raise
    # error if any are left
    if kwargs:
        raise create_unexpected_kwargs_error('run', kwargs)

The first parameter of create_unexpected_kwargs_error should be create due to the fact, that _create_container_args is only called by the container.create function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant