Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TODO]: Improve POP3 docs #3788

Open
polarathene opened this issue Jan 17, 2024 · 0 comments
Open

[TODO]: Improve POP3 docs #3788

polarathene opened this issue Jan 17, 2024 · 0 comments
Labels
area/configuration (file) area/documentation kind/improvement Improve an existing feature, configuration file or the documentation meta/help wanted The OP requests help from others - chime in! :D service/dovecot service/security/spamassassin stale-bot/ignore Indicates that this issue / PR shall not be closed by our stale-checking CI

Comments

@polarathene
Copy link
Member

polarathene commented Jan 17, 2024

Description

As detailed in this review comment, enabling POP3 will fail to retrieve any mail stored in junk (even if incorrectly flagged as spam).

For those not using Rspamd but enabling SpamAssassin, the SA_SPAM_SUBJECT ENV does not assist the POP3 situation due to the default behaviour to move mail to junk folders. This ENV should default to undef (avoids prepending anything to the mail subject header), optionally using the current default as an alternative fallback instead of undef only when related ENV to direct spam to a junk folder is explicitly disabled.


Users interested in POP3 should be made aware of this implicit configuration gotcha regardless via an update to the POP3 docs.


Another suggestion to improve UX is to catch this type of opt-in config scenario and emit warning log to raise awareness there:

This could be fixed by printing a warning if IMAP=0 and POP3=1 and MOVE_SPAM_TO_JUNK=1

@polarathene polarathene added meta/help wanted The OP requests help from others - chime in! :D service/dovecot kind/improvement Improve an existing feature, configuration file or the documentation area/documentation area/configuration (file) stale-bot/ignore Indicates that this issue / PR shall not be closed by our stale-checking CI service/security/spamassassin labels Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/configuration (file) area/documentation kind/improvement Improve an existing feature, configuration file or the documentation meta/help wanted The OP requests help from others - chime in! :D service/dovecot service/security/spamassassin stale-bot/ignore Indicates that this issue / PR shall not be closed by our stale-checking CI
Projects
None yet
Development

No branches or pull requests

1 participant