From caf6843abd978b6eea8b7093a8c83f7f6f7f8705 Mon Sep 17 00:00:00 2001 From: vantunes Date: Thu, 23 May 2024 09:42:30 +0200 Subject: [PATCH] fix: callout title is optional --- .../DsfrCallout/DsfrCallout.stories.ts | 34 +++++++++++++++++++ .../DsfrCallout/DsfrCallout.types.ts | 2 +- src/components/DsfrCallout/DsfrCallout.vue | 1 + 3 files changed, 36 insertions(+), 1 deletion(-) diff --git a/src/components/DsfrCallout/DsfrCallout.stories.ts b/src/components/DsfrCallout/DsfrCallout.stories.ts index 7485b9f2..4a41789a 100644 --- a/src/components/DsfrCallout/DsfrCallout.stories.ts +++ b/src/components/DsfrCallout/DsfrCallout.stories.ts @@ -105,6 +105,40 @@ export const MiseEnAvant = (args) => ({ `, }) + +export const MiseEnAvantSansTitre = (args) => ({ + components: { + DsfrCallout, + VIcon, + }, + + data () { + return { + ...args, + button: args.button && { + ...args.button, + onClick: args.onClick, + }, + } + }, + + template: ` + + `, + +}) +MiseEnAvantSansTitre.args = { + button: undefined, + icon: '', + content: 'Lorem ipsum dolor sit amet, consectetur adipiscing, incididunt, ut labore et dol', + titleTag: undefined, +} + const buttonOnclick = fn() MiseEnAvant.args = { title: 'Titre de la mise en avant', diff --git a/src/components/DsfrCallout/DsfrCallout.types.ts b/src/components/DsfrCallout/DsfrCallout.types.ts index 9b019899..29c32625 100644 --- a/src/components/DsfrCallout/DsfrCallout.types.ts +++ b/src/components/DsfrCallout/DsfrCallout.types.ts @@ -2,7 +2,7 @@ import type { OhVueIcon as VIcon } from 'oh-vue-icons' import type { DsfrButtonProps } from '../DsfrButton/DsfrButton.types' export type DsfrCalloutProps = { - title: string + title?: string content: string titleTag?: 'h1' | 'h2' | 'h3' | 'h4' | 'h5' | 'h6' button?: DsfrButtonProps diff --git a/src/components/DsfrCallout/DsfrCallout.vue b/src/components/DsfrCallout/DsfrCallout.vue index 5cc87246..0d4189c8 100644 --- a/src/components/DsfrCallout/DsfrCallout.vue +++ b/src/components/DsfrCallout/DsfrCallout.vue @@ -28,6 +28,7 @@ const iconProps = computed(() => dsfrIcon.value ? undefined : typeof props.icon v-bind="iconProps" />