-
-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for BigEasy's Timezone #304
Comments
I completed a first pass at the interface, and the only notable issues were that: For the
By rolling over the oversized fields. While that's arguably "incorrect", all real world timestamps will be generated by a database or API calls, and not hand written by humans, so malformed dates like these that are correctly formed but have oversized fields should be quite uncommon. As a human, it makes sense to me that "11:60" would be corrected to "12:00". Since For the From reading the docs, I agree with BigEasy's position that Timezone is a focused library that only deals with timezone aware date math and formatting, not general parsing. However, it would be nice to use the same locale data for |
@whitehat101 What prevents you to use BigEasy's Timezone? For instance, I would imagine you could control the component and concert the date with it. |
I'm interested in support for BigEasy's Timezone library. It's main unique feature is that it uses strftime formatting tokens (from GNU's version of the UNIX date utility), as used in most C based backend languages. It's under 3K minified and gzipped.
If I can make a PR that implements the interface, do you have any concerns about maintaining it as part of date-io?
http://bigeasy.github.io/timezone/
https://github.com/bigeasy/timezone
The text was updated successfully, but these errors were encountered: