Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dubious Customer type #40

Closed
bitemyapp opened this issue Apr 18, 2016 · 2 comments
Closed

Dubious Customer type #40

bitemyapp opened this issue Apr 18, 2016 · 2 comments

Comments

@bitemyapp
Copy link
Contributor

https://github.com/dmjio/stripe/blob/master/stripe-core/src/Web/Stripe/Types.hs#L245-L263

Sum of product with exported record fields is a good way to get accidental partial functions. Is there a reason it is implemented in this manner for what should probably be a split out sum type or error condition of the GetCustomer request?
@dmjio
Copy link
Owner

dmjio commented Apr 18, 2016

yea, this is a known problem, #18

@dmjio dmjio mentioned this issue Oct 1, 2016
Closed
@dmjio
Copy link
Owner

dmjio commented Mar 4, 2017

Closing because duplicate of #18

@dmjio dmjio closed this as completed Mar 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bitemyapp @dmjio