Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restructure code making files smaller #93

Open
1 of 2 tasks
djay opened this issue Oct 2, 2021 · 4 comments
Open
1 of 2 tasks

restructure code making files smaller #93

djay opened this issue Oct 2, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@djay
Copy link
Owner

djay commented Oct 2, 2021

make it easier for new people to find code and understand it

  • split covid_data into covid_data_dash.py etc. refactor covid data #174
  • move related plots into functions. covid_plot.plot_deaths etc
@djay
Copy link
Owner Author

djay commented Oct 2, 2021

@reduxionist thoughts?

@reduxionist
Copy link
Collaborator

reduxionist commented Oct 2, 2021

I think this would make it much easier to onboard new contributors to the project as it can be hard to puzzle out how things works when you click the outline view and just get 2 functions for covid_plot, versus 50+ for the covid_data module even though the latter is only twice as many SLoC as the former.

It's all working fine as purely procedural code, but are there components of the restructuring you see becoming OOP? Dashboard so often end up being ugly piles of OOP for some reason... 😉

Despite focusing on covid_plot first in my comment, I think both tasks are equally valuable. covid_data definitely qualifies for multi-module status now, IMHO.

@reduxionist reduxionist added the enhancement New feature or request label Oct 2, 2021
@djay
Copy link
Owner Author

djay commented Oct 3, 2021

The only thing I was thinking of making an object for was to contain all the various dataframes. To make it easier for scrapers to add to multiple frames and easier to pass to the plot.
Some methods could move to it like import and export and don't think a lot needs to.

@reduxionist
Copy link
Collaborator

Yeah that sounds reasonable to me if you decide to go there, nothing radical just a structure that some devs may be more comfortable wrapping their brains around. idk. my coding history predates my knowledge of OOP, so to me it's six of one a half-dozen of the other... ;)

@djay djay self-assigned this Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants