Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating benchmarks from djangobench which use run_comparison_benchmark #5

Open
deepakdinesh1123 opened this issue May 11, 2022 · 1 comment

Comments

@deepakdinesh1123
Copy link
Contributor

I was migrating some of the benchmarks from djangobench and I noticed that the benchmarks default_middleware and multi_value_dict use the utils.run_comparison_benchmark method to compare two benchmarks, ASV does not support a direct comparison between different benchmark methods. How should I implement this?

@smithdc1
Copy link
Member

smithdc1 commented Jun 2, 2022

In the case of multi_value_dict its done to compare to a pure dictionary. I think it's fine to just benchmark the django class.

IIRC this is one of the core django classes so this one area we would like to keep track of. I'd expect small gains here will quickly add up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants