Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

500 Internal Server Error when filtering with undefined value in _eq or _contains #22042

Open
KB1RD opened this issue Apr 1, 2024 · 0 comments · May be fixed by #22048
Open

500 Internal Server Error when filtering with undefined value in _eq or _contains #22042

KB1RD opened this issue Apr 1, 2024 · 0 comments · May be fixed by #22048
Assignees
@paescuj
Labels
🍰 Bug 📁 REST

Comments

@KB1RD
Copy link

KB1RD commented Apr 1, 2024

Describe the Bug

Stack trace:

test-directus-1  | [17:00:55] GET /items/Profiles?fields=id&fields=Name&fields=Bio&fields=Profile_Picture&fields=Links&fields=Tags.Tags_id&limit=25&page=1&filter=%7B%22Name%22:%7B%7D%7D 500 5ms
test-directus-1  | [17:00:55.690] ERROR: Cannot convert undefined or null to object
test-directus-1  |     err: {
test-directus-1  |       "type": "TypeError",
test-directus-1  |       "message": "Cannot convert undefined or null to object",
test-directus-1  |       "stack":
test-directus-1  |           TypeError: Cannot convert undefined or null to object
test-directus-1  |               at Function.keys (<anonymous>)
test-directus-1  |               at getFilterPath (file:///directus/node_modules/.pnpm/file+api_@[email protected][email protected][email protected][email protected]/node_modules/@directus/api/dist/utils/apply-query.js:612:29)
test-directus-1  |               at getFilterPath (file:///directus/node_modules/.pnpm/file+api_@[email protected][email protected][email protected][email protected]/node_modules/@directus/api/dist/utils/apply-query.js:617:22)
test-directus-1  |               at addJoins (file:///directus/node_modules/.pnpm/file+api_@[email protected][email protected][email protected][email protected]/node_modules/@directus/api/dist/utils/apply-query.js:248:32)
test-directus-1  |               at file:///directus/node_modules/.pnpm/file+api_@[email protected][email protected][email protected][email protected]/node_modules/@directus/api/dist/utils/apply-query.js:244:21
test-directus-1  |               at Array.forEach (<anonymous>)
test-directus-1  |               at addJoins (file:///directus/node_modules/.pnpm/file+api_@[email protected][email protected][email protected][email protected]/node_modules/@directus/api/dist/utils/apply-query.js:243:23)
test-directus-1  |               at applyFilter (file:///directus/node_modules/.pnpm/file+api_@[email protected][email protected][email protected][email protected]/node_modules/@directus/api/dist/utils/apply-query.js:232:5)
test-directus-1  |               at applyQuery (file:///directus/node_modules/.pnpm/file+api_@[email protected][email protected][email protected][email protected]/node_modules/@directus/api/dist/utils/apply-query.js:39:30)
test-directus-1  |               at getDBQuery (file:///directus/node_modules/.pnpm/file+api_@[email protected][email protected][email protected][email protected]/node_modules/@directus/api/dist/database/run-ast.js:175:42)
test-directus-1  |     }

To Reproduce

For example, using the filter examples from the docs, one could run ?filter={ "first_name": {}} instead of ?filter={ "first_name": { "_eq": "Rijk" }} on a table with a first_name field.

This should likely return 400 bad request instead of 500.

Directus Version

v10.10.4

Hosting Strategy

Self-Hosted (Docker Image)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paescuj paescuj

Labels
🍰 Bug 📁 REST
Projects
Software Roadmap
Status: 🆕 Needs Triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix handling of invalid and empty filter queries directus/directus
2 participants
@paescuj @KB1RD