Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Vue example doesn't work - docker-compose file is invalid #192

Closed
phlummox opened this issue May 25, 2023 · 1 comment
Closed

Vue example doesn't work - docker-compose file is invalid #192

phlummox opened this issue May 25, 2023 · 1 comment

Comments

@phlummox
Copy link

On Ubuntu at least, it appears pull request #190 does not, in fact, fix CORS issues, but rather breaks the docker-compose file.

Version used

  • this repository: commit afd391c
  • directus: 9.22.1
  • docker-compose: version 1.24.0 (build 0aa59064), also tested with version 1.25.0 (installed using apt-get, build unknown)

Steps to reproduce (on Ubuntu 22.04)

  • Clone the repo

    git clone https://github.com/directus/examples

  • In a terminal, cd into directus within the repo, and docker-compose up

Expected behaviour

The containers specified in the docker-compose.yml file should be started.

Actual behaviour

Docker-compose fails with an error:

ERROR: The Compose file './docker-compose.yml' is invalid because:
services.directus.environment.CORS_ENABLED contains true, which is an invalid type, it should be a string, number, or a null

Comments

The same error also occurs on Fedora 38, running docker-compose version 1.29.2. I'm curious as to how pull requests to this repository are being tested before they're merged. If no testing of pull requests is being done, perhaps that's something you could incorporate into your processes.

It might also be a good idea to test that bugs are fixed before they are closed, since even a very cursory attempt to reproduce bug #189 would likely have revealed the bug being reported in this issue.

I realise the examples in this repo aren't intended to be "production ready", but still, closing bugs as fixed when they are not doesn't seem like best practice.

@paescuj
Copy link
Contributor

paescuj commented Jul 7, 2023

Back then it has been tested and still works with Compose V2 (see https://docs.docker.com/compose/migrate/).
Nevertheless, it should now also work with the old docker-compose command after b3229b2.

@paescuj paescuj closed this as completed Jul 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants