-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature request] Variable item height #1
Comments
I'm thinking about ways to implement this. One option would be to say that each cell has it's own height but the row height is given by the max height cell in the respective row. So it should be possible to do one single pass on each vsData change to compute meta data on row positions and keep the scroll and resizing performance. |
By the way, any thoughts at this point on how much effort this feature will take and/or the general timeline on when it might eventually be implemented? |
Can't give you a timeline on that.. If I would know the heights of the cells in advance it would be no problem.. this definitely needs some research.. |
Got it, thanks. Well, in that case, what about an option to do something like this?
Edit: Nevermind, this idea probably doesn't make sense. It'd help in some cases where you're incrementally appending items and just don't want too many elements in the DOM at any one time, but if you have a massive list (say, 100k items) right from the start then you're still going to have to render all 100k of those items during the initial load, which defeats the point / would probably crash the browser tab. I guess the best solution then is probably just some variation of allowing |
Yeah, this feature is not trivial... at least there is this problem, you've added in your edit :/ |
Ideally, this option would be able to make
itemHeight
be treated as a static height for only off-screen items, with items in the viewport being rendered with their normal dynamic heights.Alternatively,
itemHeight
could be expanded to acceptnumber|(item: any) => number
and/or each item could optionally include a property (something likeodVirtualScrollHeight
) that would override the defaultitemHeight
for that particular item.The text was updated successfully, but these errors were encountered: