Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register a new URL and Link in Linkcheck whenever a contact is inserted in TinyMCE #3280

Open
1 task done
Tracked by #2955
charludo opened this issue Dec 9, 2024 · 0 comments
Open
1 task done
Tracked by #2955
Labels
deadline Needs to be fixed in the given time enhancement This improves an existing feature
Milestone

Comments

@charludo
Copy link
Contributor

charludo commented Dec 9, 2024

Motivation

Contacts inserted into TinyMCE in #3169 are picked up by linkcheck eventually. But for users, it is not at all apparent why this doesn't happen immediately, potentially leading to confusion when they have inserted a contact in a page, but that page is not shown in the contact's list of pages it is embedded in.

It can also lead to potential inconsistencies:

  • insert contact "A" into a page, save
  • go to "A"s contact details
  • change "A"s name to "B"
  • most likely, Linkcheck has not caught the embedding of the contact in the page yet, and so that page will not be updated, still showing "A".

Proposed Solution

  • the creation of a contact through the Contact Form should create a linkcheck URL object, where the URL in question is the contact's full_url. It should either be checked immediately, or set to be valid during its creation
  • inserting the contact into TinyMCE should query that URL object, and create a new related Link object

Essentially, force linkcheck to recognize the contact.

Alternatives

None, really

Related Issues

Blocked by:

@charludo charludo added enhancement This improves an existing feature deadline Needs to be fixed in the given time labels Dec 9, 2024
@charludo charludo added this to the 24Q4 milestone Dec 9, 2024
@charludo charludo changed the title Register a new URL and Link in Linkcheck whenevera contact is inserted in TniyMCE Register a new URL and Link in Linkcheck whenever a contact is inserted in TinyMCE Dec 9, 2024
@JoeyStk JoeyStk modified the milestones: 24Q4, Next-up Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deadline Needs to be fixed in the given time enhancement This improves an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants