Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

External calendars created in outlook with recurring events cannot be imported #3227

Open
Tracked by #2967
david-venhoff opened this issue Nov 19, 2024 · 2 comments · May be fixed by #3273
Open
Tracked by #2967

External calendars created in outlook with recurring events cannot be imported #3227

david-venhoff opened this issue Nov 19, 2024 · 2 comments · May be fixed by #3273
Assignees
@david-venhoff
Labels
bug Something isn't working effort: low Should be doable in <4h prio: high Needs to be resolved ASAP.
Milestone
Next-up

Comments

@david-venhoff
Copy link
Member

Describe the Bug

Outlook generates some attributes in the recurrence rule that we don't support right now, which causes the import to fail.

Steps to Reproduce

  1. Add external calendar with url https://github.com/user-attachments/files/17816539/outlook.calendar.txt
  2. See errors on import

Expected Behavior

No errors

Actual Behavior

errors

Related Issues

Discovered here: #3110 (comment)
@david-venhoff david-venhoff added the bug Something isn't working label Nov 19, 2024
@JoeyStk JoeyStk added effort: low Should be doable in <4h prio: high Needs to be resolved ASAP. labels Nov 19, 2024
@JoeyStk JoeyStk added this to the 24Q4 milestone Nov 19, 2024
@david-venhoff david-venhoff self-assigned this Nov 20, 2024
@david-venhoff david-venhoff mentioned this issue Nov 22, 2024
Merged
@david-venhoff
Copy link
Member Author

The remaining rrules not fixed by #3229 contain weekdays with frequencies, like BYDAY=-1SU. These are currently not really supported by the icalendar library. Because of that, I decided to block this issue on collective/icalendar#749.

If we really want to fix these edge cases before, we can implement this ourselves.

@david-venhoff david-venhoff added the blocked Blocked by external dependency label Nov 23, 2024
@david-venhoff
Copy link
Member Author

Update: The pr at icalendar is now merged. Unfortunately, it contained a breaking change, so there is probably no update coming soon.

@JoeyStk JoeyStk removed the blocked Blocked by external dependency label Dec 3, 2024
@david-venhoff david-venhoff linked a pull request Dec 6, 2024 that will close this issue
Open
@MizukiTemma MizukiTemma mentioned this issue Dec 12, 2024
Open
20 tasks
@JoeyStk JoeyStk modified the milestones: 24Q4, Next-up Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@david-venhoff david-venhoff

Labels
bug Something isn't working effort: low Should be doable in <4h prio: high Needs to be resolved ASAP.
Projects
None yet
Milestone
Next-up
Development

Successfully merging a pull request may close this issue.

Support rrules with BYDAY frequencies digitalfabrik/integreat-cms
2 participants
@JoeyStk @david-venhoff