Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude contact card from HIX score calculation #3268

Open
1 task done
Tracked by #2955
charludo opened this issue Dec 4, 2024 · 0 comments · May be fixed by #3281
Open
1 task done
Tracked by #2955

Exclude contact card from HIX score calculation #3268

charludo opened this issue Dec 4, 2024 · 0 comments · May be fixed by #3281
Assignees
@charludo
Labels
bug Something isn't working deadline Needs to be fixed in the given time effort: low Should be doable in <4h prio: high Needs to be resolved ASAP.
Milestone
Next-up

Comments

@charludo
Copy link
Contributor

charludo commented Dec 4, 2024

Describe the Bug

The contact card negatively affects the HIX score, even though it should not.

Steps to Reproduce

  1. Save page, see HIX score
  2. Insert Contact Card
  3. save page, see reduced HIX score

Expected Behavior

Hix score unaffected.

Actual Behavior

Hix Score severely affected.

Additional Information

Just strip the contact card from the string passed to Textlab.

Alternative

Remove all contentenditable="false" blocks from the string before passing to Textlab. Would future-proof a little bit, and IMO it makes sense to not include content in the score calculation on which users have no influence?

Related Issues

Depends on
@charludo charludo added bug Something isn't working prio: high Needs to be resolved ASAP. effort: low Should be doable in <4h deadline Needs to be fixed in the given time labels Dec 4, 2024
@charludo charludo added this to the 24Q4 milestone Dec 4, 2024
This was referenced Dec 4, 2024
Merged
Open
@charludo charludo self-assigned this Dec 9, 2024
@MizukiTemma MizukiTemma mentioned this issue Dec 9, 2024
Open
25 tasks
@JoeyStk JoeyStk modified the milestones: 24Q4, Next-up Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@charludo charludo

Labels
bug Something isn't working deadline Needs to be fixed in the given time effort: low Should be doable in <4h prio: high Needs to be resolved ASAP.
Projects
None yet
Milestone
Next-up
Development

Successfully merging a pull request may close this issue.

Exclude contact cards (and other non-editable blocks) from HIX digitalfabrik/integreat-cms
2 participants
@charludo @JoeyStk