Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Confusing order of push notifications in Integreat App/Website #2994

Open
MizukiTemma opened this issue Aug 13, 2024 · 5 comments · May be fixed by #3164
Open

Confusing order of push notifications in Integreat App/Website #2994

MizukiTemma opened this issue Aug 13, 2024 · 5 comments · May be fixed by #3164
Assignees
@PeterNerlich
Labels
blocked Blocked by external dependency enhancement This improves an existing feature needs-internal-discussion Us developers need to discuss first which way of implementation is considered to be the best question Further information is requested ui-ux Issues that requires an UI/UX perspective.

Comments

@MizukiTemma
Copy link
Member

Motivation

Push notifications are deleted after a certain period of time (currently 28 days), but sometimes push notifications that are older than 28 days appear in the message list in Integreat Website/app. This happened as a push notification was created more than 28 days ago but sent at a later time, which is whithin 28 days (a real example: today is 13.08.2024, a push notification was created on 21.06.2024, therefore older than 28 days but shown in the website/app, because it was sent on 18.07.2024).

This is confusing. We have to change how to sort push notifications and how to count their "age".

Proposed Solution

TBD

Alternatives

Leave it as it is and get confused sometimes

User Story

Additional Context

See the context here

Design Requirements

UI/UX team will give us an input how to sort/calculate age of push notifications.
@MizukiTemma MizukiTemma added feature New feature or request blocked Blocked by external dependency enhancement This improves an existing feature ui-ux Issues that requires an UI/UX perspective. question Further information is requested needs-internal-discussion Us developers need to discuss first which way of implementation is considered to be the best and removed feature New feature or request labels Aug 13, 2024
@osmers
Copy link

osmers commented Aug 21, 2024

We also just received an email from a municipality exactly regarding this issue - they also suggested to show the publish/sending date instead of the creation/last update date.
I think that makes a lot of sense - especially if some messages are created well in advance

@JoeyStk JoeyStk added this to the 24Q4 milestone Aug 27, 2024
@PeterNerlich
Copy link
Collaborator

My gut feeling is that we should simply check in the view, when displaying to the user, whether the last modified timestamp or the sent timestamp is greater and just use that for sorting

@osmers
Copy link

osmers commented Aug 28, 2024

I had a chat with @nikolahoff and she agreed that the most important thing is having the most recent notification/change up top - so in her opinion there is no problem with sorting by the most current date.
@PeterNerlich could you maybe open an issue in the app board?

@osmers osmers moved this to Done in team-uiux 🎨 Aug 28, 2024
@osmers osmers assigned PeterNerlich and unassigned osmers Aug 28, 2024
@osmers
Copy link

osmers commented Oct 2, 2024

@PeterNerlich are the labels on this issue still correct? And did you open the app board issue?

@PeterNerlich PeterNerlich mentioned this issue Oct 8, 2024
Closed
@PeterNerlich
Copy link
Collaborator

It turns out we do sorting on CMS side after all and also don't expose the sent date via the api at all, so this becomes a task for us once again

@PeterNerlich PeterNerlich reopened this Oct 31, 2024
@PeterNerlich PeterNerlich linked a pull request Oct 31, 2024 that will close this issue
Open
@JoeyStk JoeyStk removed this from the 24Q4 milestone Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PeterNerlich PeterNerlich

Labels
blocked Blocked by external dependency enhancement This improves an existing feature needs-internal-discussion Us developers need to discuss first which way of implementation is considered to be the best question Further information is requested ui-ux Issues that requires an UI/UX perspective.
Projects
team-uiux 🎨
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sort news/push notifications digitalfabrik/integreat-cms
4 participants
@PeterNerlich @osmers @JoeyStk @MizukiTemma