Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2024-11-07] Finalize permission setting for contact information #2958

Open
Tracked by #2955
MizukiTemma opened this issue Aug 1, 2024 · 1 comment
Open
Tracked by #2955
Labels
blocked Blocked by external dependency deadline Needs to be fixed in the given time feature New feature or request
Milestone

Comments

@MizukiTemma
Copy link
Member

MizukiTemma commented Aug 1, 2024

Motivation

So far we have kept the new feature contact information only available for CMS Team and Service Team for test purpose by a very strict permission setting. Now we make it available for users.

Proposed Solution

Change the permission setting of the item menu in the navigation bar and eventually add permission checks in the related views.

---- Munincipality users ------------------------------------

role view create edit archive delete
Management
Editor
Author
Event manager
Observer *1 *1 *2

*1 only if they can edit at least one page
*2 only the contacts embedded in the pages they can edit

---- Staff users ----------------------------------------------

role view create edit archive delete
CMS Team
Service Team
App Team
Marketing Team

The principle is "If I can edit at least one page, I can view contacts and create a new one. I can edit the existing contacts that are embedded in the pages I can edit."

The table for munincipality users is made based on this principle. I put ✅ for Marketing Team × View, although they cannot edit anything, becuase it is probably useful for them to "view" as staff.

Delete and archive permissions are given if they can delete/archive pages.

Alternatives

Keep this cool feature a secret among us or allow everyone to do whatever they want to with contact objects.

User Story

Additional Context

Design Requirements

@MizukiTemma MizukiTemma added feature New feature or request blocked Blocked by external dependency labels Aug 1, 2024
@MizukiTemma MizukiTemma added this to the 24Q3 milestone Aug 13, 2024
@JoeyStk JoeyStk modified the milestones: 24Q3, 24Q4 Aug 13, 2024
@JoeyStk JoeyStk changed the title Finalize permission setting for contact information [7.11.24] Finalize permission setting for contact information Aug 16, 2024
@JoeyStk JoeyStk added the deadline Needs to be fixed in the given time label Aug 16, 2024
@JoeyStk JoeyStk changed the title [7.11.24] Finalize permission setting for contact information [2024-11-07] Finalize permission setting for contact information Oct 4, 2024
@MizukiTemma
Copy link
Member Author

MizukiTemma commented Oct 31, 2024

The tests introduced by #3162 and #3168 will probably need adjustment too.

@JoeyStk JoeyStk modified the milestones: 24Q4, 25Q1 Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Blocked by external dependency deadline Needs to be fixed in the given time feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants