Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open external links in new tab #2990

Open
ztefanie opened this issue Nov 12, 2024 · 7 comments
Open

Open external links in new tab #2990

ztefanie opened this issue Nov 12, 2024 · 7 comments
Assignees
Labels
good first issue Good for newcomers ready Task Web Affects the web project

Comments

@ztefanie
Copy link
Member

ztefanie commented Nov 12, 2024

Is your feature request related to a problem? Please describe.
As a user i want to easily go back to integreat after opening a external link

Describe the solution you'd like
External links should be opened in a new link.
Make sure that best practices for opening links in a new tab are applied.

Describe alternatives you've considered
Keep it as it is

Additional context

@ztefanie ztefanie added Web Affects the web project Task labels Nov 12, 2024
@bahaaTuffaha
Copy link
Contributor

Thinking out loud:
For any Link from react-router-dom or tag just add target='_blank'

@steffenkleinle
Copy link
Member

@ztefanie we had the same discussion a few years back, see https://chat.tuerantuer.org/digitalfabrik/pl/rj7ars9mmfbg8na47eyz78z5be.
In the end, we decided to keep opening external links in the same tab. Perhaps we should check if we actually think that we should change this now. Personally I agree that it probably makes sense though.

@ztefanie
Copy link
Member Author

yeah i remembered this too, but as both of our designers agreed with the target group feedback that this would be an improvement, i think we have enough input / expertise to do it.

@steffenkleinle steffenkleinle moved this to Next Up in team-app Nov 19, 2024
@steffenkleinle steffenkleinle added this to the Roadmapping T36K milestone Nov 22, 2024
@LeandraH
Copy link
Contributor

Thinking out loud: For any Link from react-router-dom or tag just add target='_blank'

@bahaaTuffaha Yup, perfect, do you want to take on this one? You'll have to figure out how to get the target into the RemoteContent :)

@bahaaTuffaha
Copy link
Contributor

RemoteContent? 🤔 we either adjust the content (my guess is from cms)😇 or inject some JavaScript to webview 😈

@LeandraH
Copy link
Contributor

The file is called RemoteContent :) We could ask the CMS team to adjust this but I think it's more of an App behavior.

@dkehne
Copy link
Contributor

dkehne commented Dec 16, 2024

I have just added the infos from Open Project / Mattermost here in an anonymized way because we use that issue as an external test issue (applicant)
Infos OP and MM.pdf

@steffenkleinle steffenkleinle self-assigned this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers ready Task Web Affects the web project
Projects
Status: Next Up
Development

No branches or pull requests

5 participants