Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve getApplicationUrlWithQueryParams test #1808

Open
f1sh1918 opened this issue Dec 2, 2024 · 0 comments
Open

Improve getApplicationUrlWithQueryParams test #1808

f1sh1918 opened this issue Dec 2, 2024 · 0 comments
Labels
Task

Comments

@f1sh1918
Copy link
Contributor

f1sh1918 commented Dec 2, 2024

Is your feature request related to a problem? Please describe.
Currently we didn't mock buildConfig nor BuildContext which would simplify some tests and functions like get_application_url_test. Maybe some additional library will bee needed mockito

Describe the solution you'd like

  • adjust the function to only receive BuildContext and buildConfig and avoid passing multiple String parameters
  • mock BuildContext and buildConfig and adjust the tests to still work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task
Projects
team-app
Status: No status
Milestone
No milestone
Development

No branches or pull requests
1 participant
@f1sh1918