Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor translation keys #1770

Open
ztefanie opened this issue Nov 13, 2024 · 0 comments
Open

Refactor translation keys #1770

ztefanie opened this issue Nov 13, 2024 · 0 comments
Labels
discussion-needed We need to resolve the questions in the issue. Task

Comments

@ztefanie
Copy link
Member

Currently our translation keys in the translation.json have a "messy" structure as they need to fit the format the current json in the application database table are.

E.g. currently the structure for organization contacts is:

    "organizationContact": {
      "title": "Kontaktperson der Organisation",
      "name": "Vor- und Nachname der Kontaktperson in der Organisation",
      "telephone": "Telefon",
      "email": "E-Mail-Adresse",
      "hasGivenPermission": "Die Kontaktperson hat der Weitergabe ihrer Daten zum Zwecke der Antragsverarbeitung zugestimmt und darf zur Überprüfung kontaktiert werden"
    },

it would be nicer to have a none nested structure with unique keys, e.g. organizationContactName

To achieve this we have two options

  1. Migrate the existing jsons in the production database
  2. Add "key-v2" field to every value in the json with the final naming we want to have, then after e.g. 1 year when all old applicaitons without these keys are processed or deleted we use these keys and for new application we do no longer add the old v1 "keys".

I think version 2 would be the better option, because it will be quite ugly to update all the production data.

@ztefanie ztefanie added the Task label Nov 13, 2024
@ztefanie ztefanie added the discussion-needed We need to resolve the questions in the issue. label Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion-needed We need to resolve the questions in the issue. Task
Projects
Status: No status
Development

No branches or pull requests

1 participant